-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build.gradle #21
base: master
Are you sure you want to change the base?
Conversation
with the added code it also generates *-sources.jar and *-docs.jar . I am new with Bintray but I had the surprise of package rejection because of missing sources & docs. That code is from http://stackoverflow.com/questions/11474729/how-to-build-sources-jar-with-gradle and it was given to be by someone from support, telling me to add the missing jars.
Thank you for this @PopTudor, can you please sign JFrog's CLA so that we can merge this? |
Sorry but I'm good. |
@eyalbe4 Why do you require our address for a PR on example open source code? Why don't you just make it Apache 2.0, and only require us to say our name, email and accept? |
@LouisCAD, |
@eyalbe4 But can the address field be removed from the CLA please? I think @PopTudor would accept it if it was just a form with name, email, accept checkbox and submit button |
Let me check that internally @LouisCAD. |
@LouisCAD, |
with the added code it also generates *-sources.jar and *-docs.jar . I am new with Bintray but I had the surprise of package rejection because of missing sources & docs. That code is from http://stackoverflow.com/questions/11474729/how-to-build-sources-jar-with-gradle and it was given to me by someone from support. To be able to approve the package I had to add the missing jars.